NoMinimapDetector #500
Merged
NoMinimapDetector #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Nov 3, 2024
|
|
||
|
|
||
| NoMinimapDetector::NoMinimapDetector(Logger& logger, Color color) | ||
| : m_color(color) |
Collaborator
There was a problem hiding this comment.
Why do we need m_color and m_ball separately just for the overlay? Can't we make m_overworld do the overlay directly?
Collaborator
Author
There was a problem hiding this comment.
I wanted NoMinimapDetector's overlay to look slightly different than the Overworld detector's overlay. Overworld detector has 3 boxes in its overlay, while NoMinimapDetector's overlay is only the smallest inner box. This way, users can tell when we're looking or the Overworld, and when we're looking for no overworld.
I don't feel strongly about this though. If you prefer to use the Overworld's overlay, I can change it.
fyex
pushed a commit
to fyex/Arduino-Source
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects when Minimap no longer visible.
Useful for detecting when you finished the Olive roll.