OliveDetector #502
Merged
OliveDetector #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Nov 9, 2024
| class OliveMatcher : public ImageMatch::WaterfillTemplateMatcher{ | ||
| public: | ||
| OliveMatcher() : WaterfillTemplateMatcher( | ||
| "PokemonSV/Olive.png", Color(0,0,0), Color(255, 255, 255), 5 |
Collaborator
There was a problem hiding this comment.
How is this supposed to work? The olive can in be multiple orientations as well as being eclipsed or occulted.
Collaborator
Author
There was a problem hiding this comment.
All non-green pixels are filtered out. Then the largest blob of green is considered to be the Olive. Unlike all the other detectors, the RMSD doesn't matter much. This is why it doesn't care if the olive is eclipsed or in a different orientation, as long as it's the largest blob of green.
Collaborator
|
Rebase |
jw098
force-pushed
the
olive-detector
branch
from
0d22feb to
5dd859d
Compare
fyex
pushed a commit
to fyex/Arduino-Source
that referenced
this pull request
Jan 6, 2025
* OliveDetector * fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olive detector and all the associated functions for pushing the olive.