Mac qt6.5 fix #532
Merged
Mac qt6.5 fix #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cmake fix for MacOS
Workaround for MacOS involving QVideoFrames
Mysticial
reviewed
Feb 2, 2025
SerialPrograms/Source/CommonFramework/VideoPipeline/Backends/CameraWidgetQt6.5.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a workaround on MacOS to bypass issue of undetected video feed
All frames returned from the video sink on MacOS have an invalid presentation time despite everything else being valid. Not clear on why, possibly a QT bug or there's some mac-specific configuration that's missing.
The program thinks the video feed is not working when it actually is due to this and removing the check for duplicate frames gets around this. Not the best solution but the workaround is functional.