LGPE: game resets #548
Merged
LGPE: game resets #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Mar 13, 2025
| } | ||
| } | ||
|
|
||
| if (tolerate_update_menu){ |
Collaborator
There was a problem hiding this comment.
I think we can simplify this logic now and assume that feedback is available. This fallback system was for the old SwSh programs that could run without feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in resetting game from home, based off the resets from the other games. Does not yet handle the right joycon update, update can be suppressed for an unknown amount of time by going to home from the game and declining the update manually.
One thing of note - starting LGPE seems to disconnect all controllers. The ESP32 reconnects and continues to enter the game, but one time it didn't. It still showed as connected and paired, and the logs showed the inputs I attempted, but game/console was non-responsive. I haven't been able to replicate but its something to keep an eye out for.
Also, it works:
