Skip to content

Conversation

@jw098
Copy link
Collaborator

@jw098 jw098 commented Mar 29, 2025

No description provided.

}
if (empty_char){
// try the next color filter
continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than breaking out on the first match, you might want to run all of them anyway, then do a majority vote on the results (after throwing out obvious incorrect reads like empty string or letters). TeraCardReader does this with the star count:

const std::vector<double> DISTANCES{70, 80, 90, 100, 110, 120, 130};

The reason is that on the borderline cases may return neither an empty string nor a valid result. You'll want to result when the "signal is strongest".

@Mysticial Mysticial merged commit 59e76fe into PokemonAutomation:main Mar 31, 2025
6 checks passed
@jw098 jw098 deleted the itemprinter branch April 1, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants