LGPE Snorlax #583
Merged
LGPE Snorlax #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Apr 23, 2025
| default: | ||
| throw InternalProgramError( | ||
| &env.logger(), PA_CURRENT_FUNCTION, | ||
| "Not such sound detector as sound type " + std::to_string((size_t)type) |
Mysticial
reviewed
Apr 23, 2025
| ret.emplace_back(make_single_switch_program<AlolanTrade_Descriptor, AlolanTrade>()); | ||
| ret.emplace_back(make_single_switch_program<FossilRevival_Descriptor, FossilRevival>()); | ||
| ret.emplace_back(make_single_switch_program<GiftReset_Descriptor, GiftReset>()); | ||
| ret.emplace_back(make_single_switch_program<LegendaryReset_Descriptor, LegendaryReset>()); |
Collaborator
There was a problem hiding this comment.
Let's put this one under dev or beta until the auto-battle is added since the program won't be as useful until then.
It might also be worth experimenting with changing the clock to see if that does anything to stop the timer.
Contributor
Author
There was a problem hiding this comment.
Changing clock doesn't work.
Static legendaries don't run once the battle phase is done. The battle arrow looks like its reused in the catching menus, so I should have a solution soon. this is done.
Mysticial
reviewed
Apr 23, 2025
| pbf_mash_button(context, BUTTON_A, 15000ms); | ||
| break; | ||
| case Target::snorlax2: | ||
| pbf_mash_button(context, BUTTON_A, 25000ms); //can't test, not really worth it |
Collaborator
There was a problem hiding this comment.
Do these need to mash A for fixed durations? Can you mash A for a short amount of time, then mash B until you see the battle menu?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legendary Reset, except I'm only at Snorlax so wrote and tested on that. Shouldn't need too many changes to adjust for Mewtwo/Articuno/Zapdos/Moltres(skip cutscene button?). Opening this PR now since I don't know how long it'll take for me to get to the legendaries.
Possible future changes: improvements to the arrow detection. Also auto-killing the target. Because the battle timer doesn't stop while on the home menu. Or when the switch is in sleep mode. (Why???)
Shiny sound + battle arrow: PokemonAutomation/Packages#34
Sound recorded by muting music and cries in game.