Skip to content

Readd dpp warning silence #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pifopi merged 1 commit into from
Jun 15, 2025
Merged

Readd dpp warning silence #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions 3rdParty/dpp/DPP_SilenceWarnings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/* Silence Warnings for DPP Headers
*
* From: https://github.com/PokemonAutomation/
*
* Include this before every DPP header to silence warnings in those headers.
*
*/

#ifndef PokemonAutomation_3rdParty_DPP_SilenceWarnings_H
#define PokemonAutomation_3rdParty_DPP_SilenceWarnings_H


#if 0
#elif _MSC_VER

#pragma warning(disable:4100) // Unreferenced Formal Parameter
#pragma warning(disable:4251) // dll-interface

#elif __GNUC__

#pragma GCC diagnostic ignored "-Wunused-parameter"

#endif


#endif
1 change: 1 addition & 0 deletions SerialPrograms/Source/CommonFramework/Main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <QFileInfo>
//#include <QTextStream>
#include <QMessageBox>
#include <dpp/DPP_SilenceWarnings.h>
#include <Integrations/DppIntegration/DppClient.h>
#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/ImageResolution.h"
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/CommonFramework/Notifications/ProgramNotifications.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

#include <QFile>
#include <dpp/DPP_SilenceWarnings.h>
#include <Integrations/DppIntegration/DppClient.h>
#include "Common/Cpp/PrettyPrint.h"
#include "Common/Cpp/Json/JsonValue.h"
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/Integrations/DiscordIntegrationSettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <QHBoxLayout>
#include <QLabel>
#include <QPushButton>
#include <dpp/DPP_SilenceWarnings.h>
#include "Common/Qt/StringToolsQt.h"
//#include "CommonFramework/Globals.h"
//#include "CommonFramework/GlobalSettingsPanel.h"
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/Integrations/DppIntegration/DppClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifdef PA_DPP

#include <set>
#include <dpp/DPP_SilenceWarnings.h>
#include <dpp/dpp.h>
#include <Integrations/DppIntegration/DppClient.h>
#include <Integrations/DppIntegration/DppCommandHandler.h>
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/Integrations/DppIntegration/DppCommandHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifdef PA_DPP

#include <format>
#include <dpp/DPP_SilenceWarnings.h>
#include <dpp/dpp.h>
#include "Common/Cpp/Concurrency/ScheduledTaskRunner.h"
#include "CommonFramework/Globals.h"
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/Integrations/DppIntegration/DppUtility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#ifdef PA_DPP

#include <dpp/DPP_SilenceWarnings.h>
#include <dpp/dpp.h>
#include <Integrations/DppIntegration/DppUtility.h>
#include "CommonFramework/GlobalSettingsPanel.h"
Expand Down