Fixes memory stats on macOS #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naussika
force-pushed
the
main
branch
3 times, most recently
from
5f260bb to
d98bacc
Compare
Collaborator
|
The code does not match what I saw on my mac. The code computes total used memory as 32 GB but on my mac it's actually 40 GB. the process used memory is also larger than it should be. Activity Monitor says it's 319 MB but the code computes 450MB. |
- get rid of libproc - in case we use task_vm_info_data_t.phys_footprint or those ledgers
Collaborator
|
LGTM! Sorry I didn't check the update of this PR sooner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.