Skip to content

Fix uninitialized values #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pifopi merged 1 commit into from
Sep 7, 2025
Merged

Fix uninitialized values #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/Cpp/Options/TimeDurationOption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ std::string TimeDurationCell<Type>::time_string() const{
template <typename Type>
std::string TimeDurationCell<Type>::time_string(const std::string& text) const{
const Data& data = *m_data;
Type value;
Type value{};
std::string error = data.process(text, value);
if (!error.empty()){
return "<font color=\"red\">" + error + "</font>";
Expand Down
30 changes: 15 additions & 15 deletions SerialPrograms/Source/Controllers/SerialPABotBase/SerialPABotBase_Routines_Protocol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ uint32_t change_controller_mode(BotBaseController& botbase, uint32_t mode);

class DeviceRequest_seqnum_reset : public BotBaseRequest{
public:
pabb_MsgInfoSeqnumReset params;
pabb_MsgInfoSeqnumReset params{};
DeviceRequest_seqnum_reset()
: BotBaseRequest(false)
{}
Expand All @@ -41,7 +41,7 @@ class DeviceRequest_seqnum_reset : public BotBaseRequest{
};
class DeviceRequest_protocol_version : public BotBaseRequest{
public:
pabb_MsgRequestProtocolVersion params;
pabb_MsgRequestProtocolVersion params{};
DeviceRequest_protocol_version()
: BotBaseRequest(false)
{}
Expand All @@ -51,7 +51,7 @@ class DeviceRequest_protocol_version : public BotBaseRequest{
};
class DeviceRequest_program_version : public BotBaseRequest{
public:
pabb_MsgRequestProgramVersion params;
pabb_MsgRequestProgramVersion params{};
DeviceRequest_program_version()
: BotBaseRequest(false)
{}
Expand All @@ -61,7 +61,7 @@ class DeviceRequest_program_version : public BotBaseRequest{
};
class DeviceRequest_program_id : public BotBaseRequest{
public:
pabb_MsgRequestProgramID params;
pabb_MsgRequestProgramID params{};
DeviceRequest_program_id()
: BotBaseRequest(false)
{}
Expand All @@ -71,7 +71,7 @@ class DeviceRequest_program_id : public BotBaseRequest{
};
class DeviceRequest_program_name : public BotBaseRequest{
public:
pabb_MsgRequestProgramName params;
pabb_MsgRequestProgramName params{};
DeviceRequest_program_name()
: BotBaseRequest(false)
{}
Expand All @@ -81,7 +81,7 @@ class DeviceRequest_program_name : public BotBaseRequest{
};
class DeviceRequest_controller_list : public BotBaseRequest{
public:
pabb_MsgRequestControllerList params;
pabb_MsgRequestControllerList params{};
DeviceRequest_controller_list()
: BotBaseRequest(false)
{}
Expand All @@ -91,7 +91,7 @@ class DeviceRequest_controller_list : public BotBaseRequest{
};
class DeviceRequest_queue_size : public BotBaseRequest{
public:
pabb_MsgRequestProgramVersion params;
pabb_MsgRequestProgramVersion params{};
DeviceRequest_queue_size()
: BotBaseRequest(false)
{}
Expand All @@ -108,7 +108,7 @@ class DeviceRequest_queue_size : public BotBaseRequest{

class DeviceRequest_read_controller_mode : public BotBaseRequest{
public:
pabb_MsgRequestReadControllerMode params;
pabb_MsgRequestReadControllerMode params{};
DeviceRequest_read_controller_mode()
: BotBaseRequest(false)
{}
Expand All @@ -118,7 +118,7 @@ class DeviceRequest_read_controller_mode : public BotBaseRequest{
};
class DeviceRequest_change_controller_mode : public BotBaseRequest{
public:
pabb_MsgRequestChangeControllerMode params;
pabb_MsgRequestChangeControllerMode params{};
DeviceRequest_change_controller_mode(uint32_t controller_id)
: BotBaseRequest(false)
{
Expand All @@ -130,7 +130,7 @@ class DeviceRequest_change_controller_mode : public BotBaseRequest{
};
class DeviceRequest_reset_to_controller : public BotBaseRequest{
public:
pabb_MsgRequestChangeControllerMode params;
pabb_MsgRequestChangeControllerMode params{};
DeviceRequest_reset_to_controller(uint32_t controller_id)
: BotBaseRequest(false)
{
Expand All @@ -149,7 +149,7 @@ class DeviceRequest_reset_to_controller : public BotBaseRequest{

class DeviceRequest_request_stop : public BotBaseRequest{
public:
pabb_MsgRequestProtocolVersion params;
pabb_MsgRequestProtocolVersion params{};
DeviceRequest_request_stop()
: BotBaseRequest(false)
{}
Expand All @@ -159,7 +159,7 @@ class DeviceRequest_request_stop : public BotBaseRequest{
};
class DeviceRequest_next_command_interrupt : public BotBaseRequest{
public:
pabb_MsgRequestNextCmdInterrupt params;
pabb_MsgRequestNextCmdInterrupt params{};
DeviceRequest_next_command_interrupt()
: BotBaseRequest(false)
{}
Expand All @@ -176,7 +176,7 @@ class DeviceRequest_next_command_interrupt : public BotBaseRequest{

class DeviceRequest_system_clock : public BotBaseRequest{
public:
pabb_system_clock params;
pabb_system_clock params{};
DeviceRequest_system_clock()
: BotBaseRequest(false)
{
Expand All @@ -188,7 +188,7 @@ class DeviceRequest_system_clock : public BotBaseRequest{
};
class MessageControllerStatus : public BotBaseRequest{
public:
pabb_Message_RequestStatus params;
pabb_Message_RequestStatus params{};
MessageControllerStatus()
: BotBaseRequest(false)
{
Expand All @@ -200,7 +200,7 @@ class MessageControllerStatus : public BotBaseRequest{
};
class DeviceRequest_read_mac_address : public BotBaseRequest{
public:
pabb_MsgRequestReadMacAddress params;
pabb_MsgRequestReadMacAddress params{};
DeviceRequest_read_mac_address(uint32_t mode)
: BotBaseRequest(false)
{
Expand Down