Skip to content

Conversation

@denvoros
Copy link
Contributor

@denvoros denvoros commented Oct 3, 2025

This is a weird fix. When running on Linux, the ControllerInterface map ALL_CONTROLLER_INTERFACES was causing weird segfaults during program initialization before even hitting main. Seems like gcc on Linux was causing initialization order of static and global variables to not consider initializing some ControllerInterfaces before actually storing them or allocating the memory. Anyway, this fixes a big hurdle for Linux support.

NOTE: I haven't tested this on any other compilers or OS's, but the change is pretty minimal since ALL_CONTROLLER_INTERFACES is only used with InterfaceType::register_factory.

@Mysticial Mysticial merged commit c3f9474 into PokemonAutomation:main Oct 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants