[linux] ControllerInterface map reworked to a static getter #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird fix. When running on Linux, the ControllerInterface map
ALL_CONTROLLER_INTERFACESwas causing weird segfaults during program initialization before even hitting main. Seems likegccon Linux was causing initialization order of static and global variables to not consider initializing someControllerInterfacesbefore actually storing them or allocating the memory. Anyway, this fixes a big hurdle for Linux support.NOTE: I haven't tested this on any other compilers or OS's, but the change is pretty minimal since
ALL_CONTROLLER_INTERFACESis only used withInterfaceType::register_factory.