Add BerryBuyer; Shift Dialog Detection to avoid Japanese Furigana #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Nov 2, 2025
| : m_color(color) | ||
| , m_overlay(overlay) | ||
| , m_top(0.267838, 0.785156, 0.467618, 0.019531) | ||
| , m_top(0.267838, 0.784156, 0.467618, 0.019531) |
Collaborator
There was a problem hiding this comment.
0.001 is too tight of a margin when taking into capture card variation. Can you move it further up? Shrink it if you have to.
Can also try the bottom as well.
Contributor
Author
There was a problem hiding this comment.
Shifted it to the bottom instead
Mysticial
reviewed
Nov 2, 2025
| : m_color(color) | ||
| , m_overlay(overlay) | ||
| , m_top(0.267838, 0.784156, 0.467618, 0.019531) | ||
| , m_bottom(0.265, 0.930, 0.465, 0.020) |
Collaborator
There was a problem hiding this comment.
Btw, if you want to easily get box coordinates, you can use the Box Draw program. So if you're wondering why all the new programs have 6 digits of precision for all box coordinates it's because we're all being lazy and using Box Draw to create them for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding BerryBuyer because sometimes it's faster than resetting everything at Rust Syndicate (so that HP EVs for alphas don't go to waste, etc.)
Shifted FlatWhiteDialogDetector top detection box due to Japanese text sometimes interfering with detection (see image)