Skip to content

ML: Move data annotation file to the same folder as the image files #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gin890 merged 2 commits into from
Nov 11, 2025
Merged

ML: Move data annotation file to the same folder as the image files #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ceed4
ML: Move data annotation file to the same folder as the image files
jw098 Nov 10, 2025
09ba7dd
bug fix: use image_folder_path instead of image_path.
jw098 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions SerialPrograms/Source/ML/Programs/ML_LabelImages.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,10 @@ void LabelImages::load_image_related_data(const std::string& image_path, size_t

// see if we can load the previously created labels
const std::string anno_filename = std::filesystem::path(image_path).filename().replace_extension(".json").string();
const std::string image_folder_path = std::filesystem::path(image_path).parent_path().string() + "/";

// ensure the folder exists
std::filesystem::create_directory(ML_ANNOTATION_PATH());
m_annotation_file_path = ML_ANNOTATION_PATH() + anno_filename;
// std::filesystem::create_directory(ML_ANNOTATION_PATH());
m_annotation_file_path = image_folder_path + anno_filename; // ML_ANNOTATION_PATH() + anno_filename;
if (!std::filesystem::exists(m_annotation_file_path)){
cout << "Annotataion output path, " << m_annotation_file_path << " does not exist yet" << endl;
return;
Expand Down Expand Up @@ -641,7 +641,7 @@ std::pair<double, double> LabelImages::pixel_to_float(size_t x, size_t y) const{
void LabelImages::export_to_yolov5_dataset(const std::string& image_folder_path, const std::string& dataset_path){
m_yolo_config_file_path = dataset_path;

export_image_annotations_to_yolo_dataset(image_folder_path, ML_ANNOTATION_PATH(), dataset_path);
export_image_annotations_to_yolo_dataset(image_folder_path, image_folder_path, dataset_path); // image_folder_path, ML_ANNOTATION_PATH(), dataset_path);
}


Expand Down
2 changes: 1 addition & 1 deletion SerialPrograms/Source/ML/Programs/ML_LabelImages.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class LabelImages : public PanelInstance, public ConfigOption::Listener {

// Load image related data:
// - Image SAM embedding data file, which has the same file path but with a name suffix ".embedding"
// - Existing annotation file, which is stored in a pre-defined ML_ANNOTATION_PATH() and with the same filename as
// - Existing annotation file, which is stored in the same folder as the image and with the same filename as
// the image but with name extension replaced to be ".json".
void load_image_related_data(const std::string& image_path, const size_t source_image_width, const size_t source_image_height);

Expand Down
5 changes: 3 additions & 2 deletions SerialPrograms/Source/ML/Programs/ML_LabelImagesWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,9 @@ LabelImages_Widget::LabelImages_Widget(
this->m_program.save_annotation_to_file();

// ensure the folder exists
std::filesystem::create_directory(ML_ANNOTATION_PATH());
QDesktopServices::openUrl(QUrl(QString::fromStdString("file:///" + ML_ANNOTATION_PATH())));
// std::filesystem::create_directory(ML_ANNOTATION_PATH());
// QDesktopServices::openUrl(QUrl(QString::fromStdString("file:///" + ML_ANNOTATION_PATH())));
QDesktopServices::openUrl(QUrl(QString::fromStdString("file:///" + m_image_display_widget->image_folder_path())));
});
connect(save_anno_button, &QPushButton::clicked, this, [this](bool){
this->m_program.save_annotation_to_file();
Expand Down