Fix video rotation: compensate for 90deg counter-clockwise camera rot… #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation - Rotate display 90deg clockwise in CameraWidgetQt6 and CameraWidgetQt6.5 backends to fix display orientation - Rotate snapshots 90deg clockwise in SnapshotManager to fix aspect ratio validation - Ensures display and inference snapshots match raw frame orientation
Collaborator
|
Thanks for contributing! However, This hasn't been a problem for anyone else, and AFAICT, you're unconditionally rotating the display. So it's going to rotate it wrong for everyone else. More comments inline in the code. |
Mysticial
reviewed
Nov 21, 2025
| QPainter painter(this); | ||
| // Convert to image to bypass Qt's automatic rotation based on camera metadata | ||
| // This ensures the display matches the raw frame orientation used for inference | ||
| QImage image = frame.toImage(); |
Collaborator
There was a problem hiding this comment.
You cannot call QImage::toImage() here because this is the main Qt thread. It's too expensive and it will overload the main thread on higher resolutions and on multi-Switch programs.
QPainter is different because it renders the QVideoFrame directly to the screen with hardware acceleration.
added 4 commits
December 2, 2025 08:32
- Add verify_date_time_menu_selected() to ensure 'Date and Time' menu item is selected (not 'Time Zone') - Use single snapshot checks instead of continuous polling to avoid visual pulsing - Verify menu state before rolling date forward/backward in DailyItemFarmer - Prevents accidentally entering wrong menus (Time Zone, Region, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation