Added an option to track shiny sounds without notifications. #854
Conversation
| return false; | ||
| } | ||
|
|
||
| if (action == ShinySoundDetectedAction::NO_NOTIFICATIONS && current_count > 1) { |
There was a problem hiding this comment.
It should just be an unconditional return here. If we're ignoring shinies, we don't need to do anything here.
There was a problem hiding this comment.
What if the user selects "No Notifications" and "Take Video"
If the code returns here on every shiny the video would never be recorded. Maybe I should add a listener to this and hide the video option if no notifications are selected?
There was a problem hiding this comment.
Oh lol. I intended this to be "ignore all shinies". But this works too.
There was a problem hiding this comment.
When reading your message
" add an extra enum that will ignore all shinies (no notifications), but it will continue counting them."
I suppose I took "(no notifications)" as the literal ask. But I could see how an ignore option would be nice especially if there are more options or additional logic added later.
I have time to change this today. Let me know what you think people would find the most useful.
- Leave it as it is
- Change to ignore shinies, hide other options to avoid the questions about "Take Video dosen't work when I ignore shinies" 😆
- Add another enum to support both options. "No notifications" and "Ignore shinies do nothing"
I have no opinion on what would be the best option from above. Doesn't bother me to change anything, just let me know.
2 participants
Added an option to track shiny sounds without notifications. Keeping the current functionality of only recording one video per session (the first shiny sound. With the assumption that the user wouldn't want 50 videos of the same shiny if they leave the program running overnight.