ML: Add CPU fallback if GPU fails. LabelImages: allow user to select color of selected annotation. #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack on CPU if GPU fails.
Gin890
reviewed
Nov 26, 2025
|
|
||
| output_image_embedding.clear(); | ||
| embedding_session.run(resized_mat, output_image_embedding); | ||
| while (true){ |
Collaborator
There was a problem hiding this comment.
while true feels dangerous to me. Can you rewrite it to avoid while(true)?
| m_yolo_session->run(frame_mat_rgb, m_output_boxes); | ||
|
|
||
| // fall back to CPU if fails with GPU. | ||
| for(size_t i = 0;;i++){ |
Collaborator
There was a problem hiding this comment.
Same here. Don't use for infinite for loop when you can just have two calls of the session run, one for gpu, and one for cpu if exception is caught.
| #elif _WIN32 | ||
| #define ENABLE_WIN_GPU | ||
| #ifdef ENABLE_WIN_GPU | ||
| if (use_gpu){ |
Collaborator
There was a problem hiding this comment.
APPLE's impelemention should be inside this if(use_gpu) as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.