Reduce Logfire log noise for cleaner observability #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove explicit SQLAlchemy instrumentation from database.py - Add uninstrument() call to prevent auto-instrumentation of pg_catalog queries - Remove redundant "Starting..." and "...completed" info logs from Modal functions - Keep useful early-return logs like "Simulation already completed" - Clean up force_flush() placement in economy functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs were flooded with internal SQLAlchemy metadata queries (
SELECT pg_catalog...) and redundant start/complete messages, making it hard to see what was actually happening.Changes:
logfire.instrument_sqlalchemy()from database.pySQLAlchemyInstrumentor().uninstrument()to prevent auto-instrumentationlogfire.infocalls from Modal functions (spans already capture this)force_flush()placement to ensure spans are properly closed before flushingThe result is much cleaner logs that show meaningful application-level spans rather than internal database chatter.