Skip to content

Don't set dataset version for US simulations #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anth-volk merged 2 commits into from
Dec 11, 2025
Merged

Don't set dataset version for US simulations #2980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9d3684
fix: Don't set dataset version for US simulations; allow .py to handl…
anth-volk Dec 11, 2025
2d17e71
chore: Changelog
anth-volk Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
removed:
- Explicit setting of US dataset version in economy service
7 changes: 1 addition & 6 deletions policyengine_api/data/model_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
from policyengine_api.utils.hugging_face import get_latest_commit_tag

ENHANCED_FRS = "hf://policyengine/policyengine-uk-data/enhanced_frs_2023_24.h5"
FRS = "hf://policyengine/policyengine-uk-data/frs_2023_24.h5"

Expand Down Expand Up @@ -30,10 +28,7 @@ def get_dataset_version(country_id: str) -> str | None:
case "uk":
return None
case "us":
return get_latest_commit_tag(
repo_id="policyengine/policyengine-us-data",
repo_type="model",
)
return None
case _:
raise ValueError(f"Unknown country ID: {country_id}")

Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/services/economy_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
MOCK_EXECUTION_ID = "mock_execution_id_12345"
MOCK_PROCESS_ID = "job_20250626120000_1234"
MOCK_MODEL_VERSION = "1.2.3"
MOCK_DATA_VERSION = "2024.1.0"
MOCK_DATA_VERSION = None

MOCK_REFORM_POLICY_JSON = json.dumps(
{"sample_param": {"2024-01-01.2100-12-31": 15}}
Expand Down
Loading