Skip to content

Conversation

@anth-volk
Copy link
Collaborator

@anth-volk anth-volk commented Dec 23, 2025

Summary

This PR addresses a comprehensive set of visual fixes and improvements to enhance the PolicyEngine app v2 user experience.

Fixes #535

Issues Addressed

✅ Remove deprecated "Last Run" value

  • Removed the deprecated "Last Run" display from report output pages
  • Updated formatReportTimestamp to return "Ran recently" for unknown timestamps

✅ Remove unnecessary stack icon in the tab headers

  • Cleaned up tab header icons that were no longer needed

✅ Remove unused report return navigation

  • Removed dead navigation code that was no longer functional

✅ Titles of selected elements should be sentence case

  • Applied sentence case to "Policy information", "Dynamics information", and other section titles
  • Updated all map titles to use sentence case (e.g., "Relative household income change by local authority")

✅ Titles of maps should be in sentence case

  • Updated constituency and local authority map titles to sentence case
  • Fixed chart titles across all geographic analysis pages

✅ Titles of items on every menu should be sentence case

  • Updated menu items under Comparative analysis and map menus to use sentence case

✅ Reduce size of maps

  • Adjusted map sizing for better visual balance

✅ Improve map color scheme and background

  • Enhanced map styling to ensure un-impacted hexagons are always visible
  • Improved color contrast for better accessibility

✅ Improve metadata loading

  • Enhanced metadata loading behavior for smoother user experience

✅ Visually improve the loading page displayed when accessing via external link

  • Simplified and improved the loading screen appearance

✅ Apply green color to MTR chart line/dot and Varying Your Earnings chart

  • Harmonized chart line colors using the correct teal/green from the design system

✅ Fix param view in policy component

  • Fixed parameter display in the policy component view

✅ Redesign report overview page

  • Implemented new report overview pages with improved layout
  • Added hero metrics for Budgetary Impact, Poverty Impact, and Winners/Losers

✅ Fix parameter change indicator

  • Resolved issue where indicator sometimes showed 0 incorrectly

✅ Fix wrapping of ingredient names in ingredient display panel

  • Improved text wrapping for long ingredient names

✅ Remove dead code

  • Cleaned up unused code throughout the codebase

✅ Fix current law display

  • Fixed "Unknown policy" display to properly show "Current law"
  • Ensured current law values populate correctly in ingredient pages

✅ Add Claude visual skills

  • Added .claude/skills/ documentation for design tokens, chart standards, and ingredient patterns

Test Plan

  • Run npm run typecheck - passes
  • Run npm run lint - passes
  • Run npm run prettier - passes
  • Run npm run vitest - all relevant tests pass
  • Manual verification of visual changes in browser
  • Verify sentence case applied consistently across UI
  • Verify maps display correctly with new color scheme
  • Verify report overview page displays correctly

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
policyengine-app-v2 Ignored Ignored Dec 23, 2025 0:10am
policyengine-calculator Ignored Ignored Dec 23, 2025 0:10am
policyengine-website Ignored Ignored Dec 23, 2025 0:10am

@anth-volk anth-volk merged commit 4dc8e9a into main Dec 26, 2025
8 checks passed
@anth-volk anth-volk deleted the fix/report-visual-fixes branch December 26, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Various visual fixes and improvements

3 participants