Add UK-specific reference validation guidance #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on learnings from policyengine-uk PR #1459, add specific guidance for validating UK legislative references to distinguish between: - Establishing legislation (Acts) that provide authority but not values - Value-containing legislation (SIs, Finance Act sections) with actual rates - Uprating regulations vs. original establishing legislation Key additions: - Examples of correct UK reference patterns - Common mistakes to avoid (e.g., citing base rate to BoE Act 1998) - Guidance on what parameter types need which reference types This helps prevent adding generic Act references that don't actually contain the parameter values being referenced. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds UK-specific guidance to the
reference-validatoragent based on learnings from PolicyEngine/policyengine-uk#1459.Key Learning
When adding legislative references to UK parameters, it's critical to distinguish between:
Establishing legislation (e.g., Social Security Act 1992, National Minimum Wage Act 1998)
Value-containing legislation (e.g., SI 2024/432, Finance Act 2023 s. 6(4))
What Changed
Added section 3.1 "UK-Specific Reference Rules" covering:
Example from PR #1459
The PR initially added 294 generic legislative references that didn't contain the actual parameter values (e.g., referencing National Minimum Wage Act 1998 for the £11.44 rate instead of SI 2024/432 which actually contains it).
After correction, only verified references were added where the legislation actually contained the specific parameter values.
Impact
This guidance will help future Claude Code sessions working on UK parameters avoid the same mistake of adding plausible-but-unverified generic Act references.
🤖 Generated with Claude Code