Fix versioning action to properly create git tags #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change contents permission from 'read' to 'write' to allow pushing tags - Remove '|| true' from publish-git-tag.sh call to surface errors - Replace deprecated pkg_resources with direct pyproject.toml parsing - Fix changelog URLs to point to policyengine-uk-data (not policyengine-us-data)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32
The git tagging was broken for several reasons:
testjob inpush.yamlhadcontents: "read"but needscontents: "write"to push tagspublish-git-tag.shwas called with|| true, hiding all errorsfetch_version.pyusedpkg_resources.get_distribution()which is deprecated and may fail depending on how the package is installedpolicyengine-us-datainstead ofpolicyengine-uk-dataChanges
contentspermission from"read"to"write"in push.yaml|| truefrom the publish-git-tag.sh call so errors are visiblefetch_version.pyto parse version directly from pyproject.tomlNote
After merging, you may want to manually create the historical tags (1.0.0 through 1.29.2) if the compare links are important to you. Future versions will be tagged automatically.