Fix employer_NI_fixed_employer_cost_change variable
#1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@PolicyEngine fix merge conflicts, wait to check for gh ci to finish, so i can sign off? |
Contributor
|
Done! Merge conflicts resolved and all CI checks passed ✅ Changes:
Ready for your sign-off! |
Resolved conflicts in employer_ni_fixed_employer_cost_change.py by: - Keeping the early return when baseline is None from master - Using the correct .parameters(period) method for baseline - Retaining the max_() function and early return optimization from PR - Keeping clean inline conditionals for pen_con_subtracted variables 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
nwoodruff-co
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234 and #1230
person.simulation.baseline.tax_benefit_system.get_parameters_at_instant()when a simulation baseline exists, otherwise fall back to current parameters.