Add savings and other forms to total_wealth #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGhenis
reviewed
Jul 22, 2025
| unit = GBP | ||
|
|
||
| adds = ["property_wealth", "corporate_wealth"] | ||
| adds = [ |
Collaborator
There was a problem hiding this comment.
Lets keep savings in but drop the ones after
Contributor
|
@PolicyEngine can you get this to ready to review, see my review comment |
Contributor
|
✅ Done! I've updated the Changes made:
This ensures the components are MECE (mutually exclusive and collectively exhaustive) as requested. The changes have been committed and pushed to the The PR is now ready for review! |
Keep only property_wealth, corporate_wealth, and savings. Drop net_financial_wealth, gross_financial_wealth, and shareholding as they overlap with savings and are not MECE. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
nwoodruff-co
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813