Optimize test performance: remove validity tests and add microsimulation markers #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion markers This commit implements the "quick wins" to address slow test execution and high memory usage. Changes: - Removed test_validity.py which tested all ~698 variables with full microsimulation - Added pytest marker `microsimulation` for memory-intensive tests - Converted baseline in test_reform_impacts.py from module-level variable to pytest fixture - Updated Makefile to skip microsimulation tests by default with `make test` - Added `make test-all` to run all tests including microsimulation - Added `make test-microsimulation` to run only microsimulation tests Benefits: - Default `make test` now skips heavy microsimulation tests - Baseline microsimulation shared across reform tests instead of loading on module import - Removes validity test that loaded full dataset for every variable - Tests are now faster and use less memory for regular development 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the "quick wins" from issue #1452 to address slow test execution and high memory usage:
Changes
microsimulationmarker in pyproject.toml for memory-intensive testsbaseline = Microsimulation()to@pytest.fixture(scope="module")to avoid loading on import@pytest.mark.microsimulationmake test- Now skips microsimulation tests by default (fast)make test-all- Runs all tests including microsimulation (complete)make test-microsimulation- Runs only microsimulation testsBenefits
make testruns in seconds instead of minutesImpact
make testmake test-allnightlyCloses #1452
🤖 Generated with Claude Code