Benchmark QRF against other methods #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilwoodruff
changed the title
Contributor
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
There was a problem hiding this comment.
Looking forward to discussing later!
changelog_entry.yaml
Outdated
| changes: | ||
| changed: | ||
| - Worked on SCF imputation. | ||
| - Tried setting my environment and fix dependencies. |
Contributor
There was a problem hiding this comment.
We can leave this one out of the changelog.
changelog_entry.yaml
Outdated
| - bump: minor | ||
| changes: | ||
| changed: | ||
| - Worked on SCF imputation. |
Contributor
There was a problem hiding this comment.
We usually try to stick to definitive 'what changed in the package?' changelog entries.
Contributor
There was a problem hiding this comment.
I think we can add .ipynb_checkpoints to the .gitignore?
Contributor
|
Could you file and then link an issue covering the scope of this? Also wanted to make sure you saw PolicyEngine/policyengine-us#4257 |
juaristi22
commented
Feb 18, 2025
Collaborator
Author
juaristi22
left a comment
juaristi22
left a comment
There was a problem hiding this comment.
Fixed minor comments
nikhilwoodruff
changed the title
nikhilwoodruff
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on the SCF_imputation notebook to identify predictors for wealth (imputed variable: "networth"). Focused on two different types of predictors: demographic and financial. Run quantile loss comparison for the two with financial predictors clearly outperforming demographic ones. Will continue testing and evaluating different combinations of predictors.
Fixes #173