-
Notifications
You must be signed in to change notification settings - Fork 10
Improved CI/CD pipeline, added dependencies, and other miscellaneous improvements #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| run: pip install . | ||
| - name: Test basic import | ||
| run: python -c "import policyengine_us_data; print('Minimal import OK')" | ||
| - name: Test specific failing import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: What is the purpose of this test? Alternatively, why does this import fail, and when?
And could you add the answer as a comment above it, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning for this less common test is that the package is currently unusable when installed normally via PyPi or pip install -e . with Python 3.12 (paired with Ubuntu 24.02) but the PR pipeline doesn't catch it. That's because the dev dependencies include setuptools, which is needed for imports such as:
from policyengine_core.data import Dataset
and even
import policyengine_us_data
The latter is one of the explicit tests, so it bothered me that the PR pipeline wouldn't fail, even when the version was changed to 3.12 in the pipeline.
What do you think? If you're good with the test, I'll add some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after slight adjustments (and attempt of matrix to reduce duplication)
- Remove requirement for GITHUB_TOKEN
Now leaving Python 3.11 as it lies in the .github folder, but still adding the 3.12 matrix test.
make clean