Map county FIPS to county and prefer FIPS over ZIP code
#5735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policyengine_us/variables/household/demographic/geographic/county/county.py
Outdated
Show resolved
Hide resolved
anth-volk
force-pushed
the
feat/fips-county-mapping
branch
from
aebb901 to
e60e8ab
Compare
Collaborator
|
Non-blocking - only thing I could suggest is to think about using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5734
This PR modifies the
countyvariable to determine a situation'scountyvalue from FIPS code if all items in a given vector input possess one, otherwisecountycontinues to apply its default ZIP code-based formula. This will allow us to create households with input county FIPS values without modifying how we do society-wide simulations.Requires PolicyEngine/policyengine-us-data#195 to be closed and merged before tests will pass.