-
Notifications
You must be signed in to change notification settings - Fork 201
Fix VA spouse tax adjustment by calculating separate VAGI per person #6960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The Virginia Spouse Tax Adjustment incorrectly calculated eligibility because va_agi_person prorated combined VA AGI by Federal AGI share, spreading deductions across both spouses instead of applying them to the correct person. Changes: - Created va_age_deduction_person to calculate age deduction per person - Created va_additions_person for person-level VA additions - Created va_subtractions_person for person-level VA subtractions - Fixed va_agi_person to calculate separate VAGI from person-level components instead of prorating combined VA AGI - Added integration test for elderly head with low income case This matches the VA Form 760 Spouse Tax Adjustment Worksheet (page 12) which shows separate Virginia AGI calculation for each spouse. Fixes #6958 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6960 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 4 +2
Lines 26 58 +32
=========================================
+ Hits 26 58 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@PolicyEngine it's failing tests |
|
I ran into an issue: |
Update tests to reflect the new correct behavior where each person's VA AGI is calculated as their federal AGI +/- VA adjustments, rather than prorating the combined VA AGI. Also update uv.lock. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@DTrim99 please review, this PR is not a state ready to merge |
Summary
Fixes #6958
The Virginia Spouse Tax Adjustment incorrectly calculated eligibility because
va_agi_personprorated combined VA AGI by Federal AGI share, spreading deductions like the age deduction across both spouses instead of applying them to the correct person.Changes
va_age_deduction_person: Calculates age deduction per person based on their individual Federal AGI and age eligibilityva_additions_person: Person-level Virginia additions (currently returns 0, ready for future additions)va_subtractions_person: Person-level Virginia subtractions (currently only age deduction)va_agi_person: Now calculates separate VAGI for each person from their individual components instead of prorating combined VA AGITest Results
Technical Details
This matches the VA Form 760 Spouse Tax Adjustment Worksheet (page 12) which explicitly shows how to calculate "Separate Virginia Adjusted Gross Income" for each spouse:
The fix ensures that when a 75-year-old head with low income qualifies for a $12,000 age deduction, it only reduces their VAGI (potentially to negative), not the spouse's VAGI.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com