Skip to content

Conversation

@daphnehanse11
Copy link
Collaborator

Fixes #6364

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (9739e2f) to head (79a9606).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6987       +/-   ##
===========================================
+ Coverage   76.92%   97.02%   +20.10%     
===========================================
  Files           1        7        +6     
  Lines          39      101       +62     
  Branches        4        1        -3     
===========================================
+ Hits           30       98       +68     
+ Misses          8        2        -6     
  Partials        1        1               
Flag Coverage Δ
unittests 97.02% <100.00%> (+20.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daphnehanse11 daphnehanse11 changed the title Daphnehanse11/issue6364 Add Colorado ACA subsidies for immigrants Dec 18, 2025
daphnehanse11 and others added 6 commits December 18, 2025 14:57
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This PR should only contain Colorado OmniSalud implementation.
DC Medicaid/Alliance code is already in PR PolicyEngine#6541.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@daphnehanse11
Copy link
Collaborator Author

PR Review: Colorado OmniSalud

Note: Removed DC Medicaid code (already in PR #6541). This PR is now Colorado-only.

🔴 Critical (Must Fix)

  1. Hard-coded 12 in benefit calculation
    • File: policyengine_us/variables/gov/states/co/hcpf/omnisalud/co_omnisalud.py:33
    • Current: slcsp_monthly * 12
    • Fix: Use MONTHS_IN_YEAR constant from model_api

🟡 Should Address

  1. Income Limit Comparison

    • File: co_omnisalud_income_eligible.py:26
    • Official source states income must be "less than 150% FPL" (strict <), but code uses <=
    • Verify which is correct for Colorado
  2. 2025 Transition Sources Need Verification

    • covers_daca.yaml and covers_undocumented_children.yaml cite 2025 changes
    • Could not verify these transitions in the referenced sources
    • Note: Federal DACA ACA eligibility ended Aug 25, 2025 (DACA recipients lose ACA, not gain it)
    • Research Colorado-specific law for these transitions
  3. Missing Benefit Tests

    • No tests exist for co_omnisalud benefit amount calculation
    • Add tests verifying benefit equals SLCSP for eligible individuals

🟢 Suggestions

  1. SLCSP Period Clarification
    • slcsp is MONTH but accessed with YEAR period
    • Consider adding comment explaining the aggregation behavior

Validation Summary

Check Result
Regulatory Accuracy 2 items need verification
Code Patterns 1 hard-coded value
Vectorization ✅ Correct where() usage
Parameter Access ✅ Correct patterns
defined_for ✅ Uses StateCode.CO
Test Coverage Missing benefit tests
CI Status ✅ Passing

Verified Correct

  • ✅ Income limit 150% FPL
  • ✅ Program start 2022
  • ✅ Child max age 18
  • ✅ Immigration statuses (undocumented, DACA, TPS)
  • ✅ Variable naming conventions
  • ✅ Test formatting with underscore separators

Next Steps

To auto-fix issues: /fix-pr 6987

Or address manually:

  1. Replace * 12 with * MONTHS_IN_YEAR
  2. Verify income comparison operator
  3. Research and cite 2025 transition sources
  4. Add benefit calculation tests

🤖 Generated with Claude Code

- Replace hard-coded `* 12` with `* MONTHS_IN_YEAR` constant
- Add benefit calculation tests for co_omnisalud variable

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@daphnehanse11 daphnehanse11 marked this pull request as ready for review December 22, 2025 19:43
daphnehanse11 and others added 2 commits December 23, 2025 11:42
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update parameter descriptions to use active voice
- Add page references to documentation URLs
- Remove inline comments from parameter values
- Add defined_for = StateCode.CO to co_omnisalud.py
- Add comprehensive income eligibility tests (6 test cases)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update child_max_age.yaml label from 'CO OmniSalud' to 'Colorado OmniSalud'
- Update reference format to use #page=4 in URL instead of title
- Simplify co_omnisalud.py to use adds=['slcsp'] pattern instead of formula
- Add co_omnisalud_tax_unit_eligible variable for TaxUnit-level eligibility
- Update tests to use yearly slcsp input values

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Colorado ACA subsidies for immigrants

2 participants