Skip to content

Conversation

@daphnehanse11
Copy link
Collaborator

Fixes #7004

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.02%. Comparing base (ab00968) to head (1410230).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #7005      +/-   ##
===========================================
- Coverage   100.00%   98.02%   -1.98%     
===========================================
  Files           15        9       -6     
  Lines          213      152      -61     
  Branches         0        1       +1     
===========================================
- Hits           213      149      -64     
- Misses           0        2       +2     
- Partials         0        1       +1     
Flag Coverage Δ
unittests 98.02% <100.00%> (-1.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

daphnehanse11 and others added 3 commits December 18, 2025 10:28
…fits

- Remove new enrollment tracking (6 files deleted)
- Reorganize parameters into adult/child/senior subfolders
- Simplify immigration check to use ~is_medicaid_immigration_status_eligible
- Integrate HBI with Medicaid benefit system:
  - Add il_hbi_eligible to is_medicaid_eligible
  - Map HBI age groups to Medicaid spending categories
- Fix changelog: patch→minor, fixed→added

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@daphnehanse11 daphnehanse11 marked this pull request as ready for review December 18, 2025 18:21
daphnehanse11 and others added 2 commits December 18, 2025 13:22
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Collaborator

@hua7450 hua7450 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good implementation of the Illinois HBI program. One notable issue: the senior resource limit parameter ($17,500) exists but is not implemented in the eligibility formula. See summary comment for details and recommendations.

daphnehanse11 and others added 6 commits December 18, 2025 16:16
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@daphnehanse11
Copy link
Collaborator Author

PR Review: Illinois Health Benefits for Immigrants (HBI)

🔴 Critical (Must Fix)

  1. HBIA Program Start Date Incorrect
    • File: policyengine_us/parameters/gov/states/il/hfs/hbi/eligibility/adult/in_effect.yaml
    • Current: 2022-01-01: true
    • Should be: 2022-07-01: true
    • Source: Illinois DHS Policy page states "Expanded to ages 42-64 effective July 1, 2022"

🟡 Should Address

  1. Missing Test for Pre-July 2022 Period

    • Add test verifying someone aged 42-64 is NOT eligible in January 2022 (before HBIA started for that age group)
  2. Add Primary Regulatory Reference

    • Consider adding citation to enabling legislation: 305 ILCS 5/12-4.35 (Health Benefits for Immigrant Adults and Seniors Act)

🟢 Suggestions

  1. Senior Income Test Precision

    • In il_hbi_senior_income_level.yaml, test expects 0.777 but calculation is 11700/15060 = 0.7769... - verify rounding behavior
  2. Document Enrollment Pause (optional)

    • HBIA enrollment paused July 1, 2023; HBIS enrollment paused Nov 6, 2023
    • Current implementation only models program termination, which is acceptable for most policy analysis

Validation Summary

Check Result
Regulatory Accuracy 1 issue (HBIA start date)
Reference Quality ✅ References corroborate values
Code Patterns ✅ No hard-coded values, correct patterns
Test Coverage Good coverage, minor gap
CI Status ✅ Passing (codecov warning is non-blocking)

Verified Correct

  • ✅ Age thresholds (All Kids ≤18, HBIA 42-64, HBIS ≥65)
  • ✅ Income limits (All Kids 318% FPL, HBIA 138% FPL, HBIS 100% FPL)
  • ✅ HBIS start date (Dec 1, 2020)
  • ✅ HBIA end date (July 1, 2025)
  • ✅ Resource limit ($17,500 for seniors)
  • ✅ AABD methodology for seniors vs MAGI for children/adults
  • ✅ Immigration statuses (undocumented, DACA, TPS)
  • ✅ Vectorized operations (where/select patterns)
  • ✅ Parameter access patterns

Next Steps

To auto-fix issues: /fix-pr 7005

Or address manually:

  1. Change HBIA start date from 2022-01-01 to 2022-07-01
  2. Add test for pre-July 2022 ineligibility

🤖 Generated with Claude Code

daphnehanse11 and others added 2 commits December 22, 2025 13:32
Co-authored-by: Ziming Hua  <113824411+hua7450@users.noreply.github.com>
…dult/in_effect.yaml

Co-authored-by: Ziming Hua  <113824411+hua7450@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Illinois medicaid for undocumented immigrants

3 participants