chore: codeql advanced #418
Conversation
|
Still WIP so no need to review yet. Can't change back to draft from mobile |
| buildSettings = { | ||
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor; | ||
| CODE_SIGN_IDENTITY = ""; |
There was a problem hiding this comment.
These changes avoid code signing when building on generic destinations
pauldambra
left a comment
pauldambra
left a comment
There was a problem hiding this comment.
very low context 🤣
might be worth asking @Piccirello too
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
CI job makes sense to me, I don't understand the changes on Makefile tho
The main change is removing CodeQL job was failing with low disk space. I guess because it's running on limited resources? But anw, the change should be beneficial for the other build workflows as well which are green as well. Didn't touch any release-related scripts |
|
This looks good, though the only thing it's missing is scanning of GitHub Actions. We previously got that with the default CodeQL setup, but no longer do. Could you add that back? |
This was accidentally removed in #418.
This was accidentally removed in #418.
💡 Motivation and Context
Based on PostHog/posthog#43050 and PostHog/posthog-android#356
#skip-changelog
💚 How did you test it?
📝 Checklist