Allow wildcard for MAR repository for FindAll and FindByName#1786
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Feb 19, 2025
Merged
Allow wildcard for MAR repository for FindAll and FindByName#1786adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
anamnavi
reviewed
Jan 28, 2025
anamnavi
reviewed
Jan 28, 2025
anamnavi
approved these changes
Jan 28, 2025
Member
anamnavi
left a comment
There was a problem hiding this comment.
Left some feedback, but overall looks good!
Co-authored-by: Anam Navied <anam.naviyou@gmail.com>
alerickson
approved these changes
Jan 28, 2025
anamnavi
pushed a commit
that referenced
this pull request
Mar 6, 2025
alerickson
pushed a commit
to alerickson/PSResourceGet
that referenced
this pull request
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request to
src/code/ContainerRegistryServerAPICalls.csincludes changes to enhance the functionality of finding packages in a container registry and improve the test coverage for the MAR repository. The most important changes include adding a new URL template for listing repositories, modifying theFindAllandFindNameGlobbingmethods to use the newFindPackageshelper method, and adding new tests for wildcard searches.Enhancements to finding packages:
containerRegistryRepositoryListTemplatefor listing repositories.FindAllmethod to use the newFindPackageshelper method instead of returning an error.FindNameGlobbingmethod to use the newFindPackageshelper method instead of returning an error.FindAllRepositoriesto list all repositories in the container registry.FindPackagesto find packages using wildcards and handle MAR-specific logic.Improvements to test coverage:
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.