Bugfix for comparing file path name to determine exact match

[anamnavi]

PR Summary

Utils.cs has GetMetadataFilesFromPath() that is used by the PublishPSResource and LocalServerApiCalls classes.

In that method we find files which match the package name such as the .psd1, .ps1, .nuspec files. It catches file names that match packageName* but that includes files that should not be matched. For example, the Az.KeyVault package has 2 .psd1 files: AzKeyVault.psd1 and Az.KeyVault.Extension.psd1 and the latter was getting considered as a valid match. This PR fixes that. The string.Compare() method is already correctly determining if the filename is a correct match so the code to store that file path as a path of interest should happen in that condition set by string.Compare()

PR Context

Resolves Azure/azure-powershell#27535
Resolves #1837 #1762

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[anamnavi]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adityapatwardhan]

Can we add a test?

[adityapatwardhan]

Please add a test

[alerickson]

Looks good, agree with adding the test if it's feasible.

[anamnavi]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[alerickson]

I think it's possible this PR fixes bug #1837. Making a note for one of us to come back to this :)

[anamnavi]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Alex-AZPS]

Has this bug been fixed? And has the fix been released?

[anamnavi]

Hi @Alex-AZPS , yes this was released in 1.2.0-preview3. Let me know if you face any issues with this still.