-
Notifications
You must be signed in to change notification settings - Fork 100
Research nuget v3 dependency resolution #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Anam Navied <anam.naviyou@gmail.com>
Co-authored-by: Anam Navied <anam.naviyou@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| { | ||
| List<Dependency> pkgDeps = new(); | ||
|
|
||
| if (dependencyGroupsElement.ValueKind == JsonValueKind.Array) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a else if (tagsElement.ValueKind == JsonValueKind.String)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so-- according to https://learn.microsoft.com/en-us/nuget/api/registration-base-url-resource#catalog-entry and https://learn.microsoft.com/en-us/nuget/api/registration-base-url-resource#package-dependency-group both dependencyGroups and dependencies should be an array of objects. Under the first link tags is allowed to be a string or an array.
PR Summary
Opening this PR to run CI tests for #1778
Note: There is one test that is failing due to a bug that is being tracked here: #1837. The test is temporarily commented out.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.