Check for ModulePrefix parameter presence instead of it being a dynamic parameter#1868
Merged
alerickson merged 4 commits intomasterfrom Sep 9, 2025
Merged
Check for ModulePrefix parameter presence instead of it being a dynamic parameter#1868alerickson merged 4 commits intomasterfrom
alerickson merged 4 commits intomasterfrom
Conversation
alerickson
reviewed
Sep 3, 2025
src/code/PublishPSResource.cs
Outdated
|
|
||
| if (MyInvocation.BoundParameters.ContainsKey(nameof(ModulePrefix))) | ||
| { | ||
| if (MyInvocation.BoundParameters.ContainsKey(nameof(Repository))) // can remove if Repository is 'Mandatory' parameter |
Member
There was a problem hiding this comment.
What does "can remove if Repository is 'Mandatory' parameter" mean? What's being removed?
Member
Author
There was a problem hiding this comment.
I just meant if we make the -Repository parameter mandatory for Publish-PSResource then I'll remove the check for seeing if Repository was included in the cmdlet invocation because that condition is guaranteed.
alerickson
approved these changes
Sep 3, 2025
adityapatwardhan
approved these changes
Sep 8, 2025
Member
Author
|
@EmilienCourt please track this in favor of #1865 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
Publish-PSResourcedeclareModulePrefixas a regular parameter instead of a dynamic parameter. This allows for better error message writing and error handling with regards to how this parameter works with repositories.PR Summary
PR Context
Resolves #1827 #1806
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.