This repository was archived by the owner on Nov 26, 2020. It is now read-only.
Adding originatingElement to generated JavaBuild#28
Open
mtraynham wants to merge 1 commit intoPozo:masterfrom
mtraynham:fix
Open
Adding originatingElement to generated JavaBuild#28mtraynham wants to merge 1 commit intoPozo:masterfrom mtraynham:fix
mtraynham wants to merge 1 commit intoPozo:masterfrom
mtraynham:fix
Conversation
Contributor
Author
|
@Pozo would be great if this got merged, seems to reduce build times immensely! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapStruct 1.4.0.Final was released recently, so I was hoping to take advantage of the full benefits of Kapt annotation incremental compiling for faster builds, but it didn't seem to be working and always seemed to do a full build.
The Builder annotation processing via mapstruct-kotlin had this spurious line in the logs during the build,
I tracked down the error message to Jetbrains kapt, https://github.com/JetBrains/kotlin/blob/master/plugins/kapt3/kapt3-base/src/org/jetbrains/kotlin/kapt3/base/incremental/incrementalProcessors.kt#L126-L129. Interestingly, if you hit this, it seems to set that
isFullRebuild = true, which is probably not ideal.Adding the
originatingElementdata class to theTypeSpec.classBuilderseems to correct the issue.