Resolve MAP runtime failure due to CUDA runtime lib missing by specifying cuda version when packaging MAP#577
Resolve MAP runtime failure due to CUDA runtime lib missing by specifying cuda version when packaging MAP#577
Conversation
Signed-off-by: M Q <mingmelvinq@nvidia.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@MMelQin - will review in full before EOD, but wanted to quickly comment to say I concur with your assessment and too found that explicitly specifying Thanks for taking a look into this. |
|
I was able to build a test MAP with cuda flag set to 12. However, Holoscan version should be 3.10 for the flag to work (holoscan-cli>=3.10.0 and holoscan-cu12>=3.10.0). The current requirements.txt and setup.cfg do not state this explicitly, consider editing those before merge.. |
Great point! I will add some text in the Jupyter notebook example. Another thing is that I was thinking to update the Docs at the next release of the SDK as Doc build and publishing is one of the steps in releasing a new version, AND in the next release we move to CUDA 13 eliminating the need to specify --cuda on the commandline. However, did not have time to discuss this move to CUDA 13 in the WG meeting today, and PyTorch latest still by default uses CUDA 12.8 runtime lib. so we may not want to move to CUDA 13 yet. |



The "monai-deploy package" command for creating the MAP container image has changed to use CUDA 13 base image. However
So, the changes:
--cuda 12so that the CUDA 12 version base image will be used, though the whole output of running the Jupyter notebook was added to this PR