Add permissions to access transactions and transaction batches

[dontub]

Restrictions are applied by the field domain which is added to BankTransaction and BankTransactionGroups. Possible domains are specified by an option group. For each domain a CiviCRM permission is created which gives access to transactions and transaction groups with that domain. On import the domain can be specified. (Specifying a domain can be enforced optionally.) The previous behavior should not be changed, i.e. users that currently can access all transactions will still have access to all transactions.

• Permission check is applied on APIv4 calls.
• APIv3 calls to the two entities are replaced by APIv4 calls.
• Direct SQL queries are replaced by APIv4 calls where possible. For the remaining queries the WHERE close is adapted.
• APIv3 actions are mapped to APIv4.

systopia-reference: 25700

[jensschuppe]

Can EXTRACT() be used to replace YEARWEEK()?

[dontub]

Extracting year and week using EXTRACT() doesn't always lead to the same results, e.g.:

SELECT CONCAT(EXTRACT(YEAR FROM '2000-01-01'), EXTRACT(WEEK FROM '2000-01-01'));

results in 20000.

SELECT YEARWEEK('2000-01-01', 3);

resutls in 202001.

The year can differ in some cases, too:

The year in the result may be different from the year in the date argument for the first and the last week of the year.

https://mariadb.com/kb/en/yearweek/

[jensschuppe]

Is strtotime('+1 year') (or -1 year below) guaranteed to always work correctly regardless of leap years, leap seconds, timezones, DST and date/time of script execution?

Considering the old code did the same, this might be irrelevant here, but got me wondering …

[dontub]

Looks like PHP doesn't handle leap seconds....

php > echo date('Y-m-d H:i:s', strtotime('2016-12-31 23:59:60'));
2017-01-01 00:00:00
php > echo date('Y-m-d H:i:s', strtotime('2016-12-31 23:59:60 +1 year'));
2018-01-01 00:00:00
php > echo date('Y-m-d H:i:s', strtotime('2016-12-31 23:59:60 -1 year'));
2016-01-01 00:00:00

Otherwise I couldn't imagine any issues here.

[jensschuppe]

APIv3 encodes all other operators as arrays, e.g. 'id' => ['BETWEEN' => [1, 100]] or even 'id' => ['IS NULL' => 1] so this will change operators and values.

[dontub]

Looks like we could make use of hook_civicrm_selectWhereClause and then wouldn't need this code at all.

[bjendres]

@dontub Could you resolve the conflicts with the current master?