Skip to content

Regression test for static items with object names containing non-ASC… #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Josh-Larson merged 1 commit into from
May 5, 2025
Merged

Regression test for static items with object names containing non-ASC… #1792

Josh-Larson merged 1 commit into from
May 5, 2025

Conversation

@madsboddum
Copy link
Member

@madsboddum madsboddum commented Apr 18, 2025

…II characters

Basically catches items with names like this:

image

Error message from the failing test for that particular sword:

Champion’s Sword contains non-ASCII characters. These will not display correctly in the client. Please remove/replace these: [’]

@madsboddum madsboddum self-assigned this Apr 18, 2025
@madsboddum madsboddum added BUGFIX Fix of a bug (Pull Request) [Item] Service labels Apr 18, 2025
@Undercova Undercova requested a review from Josh-Larson April 18, 2025 20:35
@Josh-Larson Josh-Larson merged commit 188e4a1 into ProjectSWGCore:master May 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Larson Josh-Larson Awaiting requested review from Josh-Larson

Assignees

@madsboddum madsboddum

Labels

BUGFIX Fix of a bug (Pull Request) [Item] Service

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madsboddum @Josh-Larson