Skip to content

Conversation

@elevatorguy
Copy link

@elevatorguy elevatorguy commented Jun 16, 2025

4.0:


Populate extra_compile_args and extra_link_args as needed.


Regarding symlink(s) - resources:

D:\puffer>fsutil behavior query symlinkevaluation
Local-to-local symbolic link evaluation is: ENABLED
Local-to-remote symbolic link evaluation is: DISABLED
Remote-to-local symbolic link evaluation is: DISABLED
Remote-to-remote symbolic link evaluation is: DISABLED
Directory of C:\Program Files (x86)\Intel\oneAPI\dpl\2022.9\windows

09/23/2025  08:32 AM    <DIR>          .
09/23/2025  08:32 AM    <DIR>          ..
09/23/2025  08:32 AM    <SYMLINKD>     include [C:\Program Files (x86)\Intel\oneAPI\dpl\2022.9\include]

For puffer, config and resources don't have the above SYMLINKD status.

Trying git config core.symlinks true:

D:\puffer>git status
On branch local
Your branch is up to date with 'fork/local'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        typechange: config
        typechange: resources

no changes added to commit (use "git add" and/or "git commit -a")

D:\puffer>git restore resources
error: unable to create symlink resources: Permission denied

D:\puffer>git restore config
error: unable to create symlink config: Permission denied

Doesn't block training of puffer_target, but shows W0918 08:32:43.886000 5792 site-packages\torch\distributed\elastic\multiprocessing\redirects.py:29] NOTE: Redirects are currently not supported in Windows or MacOs. above initial draw of puffer dash - using 2.8.0+xpu as pytorch version - and one dialog box.

file

@elevatorguy elevatorguy marked this pull request as ready for review June 16, 2025 13:51
@elevatorguy elevatorguy changed the title changes windows Jun 16, 2025
@elevatorguy

This comment was marked as resolved.

@elevatorguy elevatorguy changed the title windows windows 11 Jun 20, 2025
@elevatorguy elevatorguy mentioned this pull request Jun 25, 2025
@elevatorguy elevatorguy force-pushed the local branch 2 times, most recently from 75f712e to bce45ca Compare July 4, 2025 19:48
@KTibow
Copy link
Contributor

KTibow commented Sep 27, 2025

D:\puffer>

Python - pufferlib/ocean/target/target.py or elsewhere:

is_resource = not(os.path.exists("pufferlib"))
if is_resource:
    resource_path = "resources/..."
else:
    resource_path = "pufferlib/resources/..."

C - somewhere not per env: //TODO - file handling (eg. like this, but better)

May be raylib issue; LoadTexture using relative instead of absolute path - see pufferlib/ocean/environment.py.

Real problem is that resources is supposed to be a symlink to pufferlib/resources. PufferLib users should either enable symlink support on their device (sounds like if you have admin you can enable dev mode to make this work?) or replace the symlink with a directory junction to get this working. I don't think it makes sense to modify the code as a workaround (unless we're going to switch all resources to pufferlib/resources or a "base path" variable).

@elevatorguy elevatorguy marked this pull request as draft September 28, 2025 00:07
@elevatorguy elevatorguy force-pushed the local branch 2 times, most recently from 37dc092 to 48618dd Compare September 29, 2025 13:36
@KTibow
Copy link
Contributor

KTibow commented Sep 29, 2025

Testing which changes are actually necessary:

  • GitHub Workflows change is currently problematic (because most envs don't use msvc-style C)
  • env_binding change seems out of scope and unneeded (I think)
  • environment.py change is genuinely needed (bindings won't import correctly otherwise)
  • pufferl.py change is genuinely needed (svmem only has active on unixlike)
  • gitignore change seems out of scope and also oddly setup (raylib* already exists, so the # Raylib section is redundant)
  • All setup.py changes aside from .replace('\\', '.') are genuinely needed

@elevatorguy elevatorguy changed the title windows 11 win64_msvc16 Oct 2, 2025
@elevatorguy elevatorguy changed the title win64_msvc16 win64_msvc16 - puffer_target Oct 2, 2025
@elevatorguy
Copy link
Author

Perhaps 8bcc454; not necessarily out-of-scope - may be needed.

@elevatorguy elevatorguy mentioned this pull request Oct 21, 2025
@elevatorguy elevatorguy changed the base branch from 3.0 to 4.0 October 24, 2025 00:03
# Conflicts:
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants