Fix cartpole standalone demo after contextualization #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 941198f ("Contextualize cartpole") moved physics parameters from #define constants to struct fields for Python configurability, but did not update cartpole.c to initialize them. This broke the standalone demo with division-by-zero / NaN errors. Initialize physics parameters using designated initializers, consistent with other ocean environments like pong.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 941198f ("Contextualize cartpole") moved physics parameters from #define constants to struct fields but did not update cartpole.c to initialize them; local compilation gets nans when run.
Added designated initializers for the physics parameters to remedy.