Add Custom Logger and types for better data handling, type checking aβ¦#22
Open
Einswilli wants to merge 1 commit intoPythonBenin:masterfrom
Open
Add Custom Logger and types for better data handling, type checking aβ¦#22Einswilli wants to merge 1 commit intoPythonBenin:masterfrom
Einswilli wants to merge 1 commit intoPythonBenin:masterfrom
Conversation
Collaborator
|
Hey @Einswilli, sorry I was quite busy. I'll take a look at your PR this week π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
β¨ Pull Request β Strong Typing & Basic Logging Module
Hi team π,
This PR introduces two key improvements aimed at increasing the quality, maintainability, and robustness of the SDK:
1. π§Ύ Added
types.pyfor Strong Typing2. πͺ΅ Introduced a Basic Logging Module
LoggingConfig) and a dedicated logger class (KKiaPayLogger).π οΈ Why This Is Split
Initially, I intended to include a larger refactor (better flexibility, extensibility, robustness, and structural consistency) in this single PR.
However, to make review, testing, and discussion easier, I decided to split it into smaller, focused pull requests.
Upcoming PRs will include:
httpxclient.Looking forward to your feedback, and thank you! π
β Einswilli