Fix VLAN 1 default state handling to prevent false removal failures #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes QualiSystems#140 - Updated verify_interface_has_no_vlan_assigned() to treat VLAN 1 as default state - VLAN 1 is now considered equivalent to 'no VLANs assigned' during cleanup - Handles both explicit (switchport trunk allowed vlan 1) and implicit VLAN 1 configs - Prevents '[FAIL] VLAN(s) ALL removal failed' errors on subsequent reservations - Added comprehensive unit tests covering various VLAN 1 configuration scenarios This fix resolves the issue where some Cisco switches show 'switchport trunk allowed vlan 1' in their default configuration state, causing VLAN connectivity setup to fail after teardown, while other switches don't show it (implied).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
This fix resolves the issue where some Cisco switches show 'switchport trunk allowed vlan 1' in their default configuration state, causing VLAN connectivity setup to fail after teardown, while other switches don't show it (implied).