Open
Conversation
…vigate to the right page
| @Test | ||
| public void verifyNavigationDevOpsConsultancy () throws InterruptedException{ | ||
| page.clickServices(); | ||
| Thread.sleep(1000); |
Contributor
There was a problem hiding this comment.
@jpottinger Is there a way can test these without explicitly calling Thread.sleep
romarioraffington
suggested changes
Aug 10, 2017
Contributor
romarioraffington
left a comment
romarioraffington
left a comment
There was a problem hiding this comment.
Looks like the spacing is a bit off. Maybe I should create a contributing.md / styles doc to list these things.
Can you ensure:
- You are using 2 spaces for tabs
- have a space between
()for{for your functions - Ensure the closing
}is inline with public
JavonDavis
suggested changes
Aug 10, 2017
JavonDavis
left a comment
JavonDavis
left a comment
There was a problem hiding this comment.
- See Romario's requests for changes regarding code style
- Please use WebDriverWait instead on forcing the Thread to sleep
- Next time the name of the pull request should indicate what feature you want to be merged
|
@romarioraffington I think a linter that automatically runs on the repo would be a better approach to enforcing code style than the contributing.md |
Author
|
@JavonDavis WebDriverWait was giving error and issues. Will try to implement again. |
Author
|
@romarioraffington @JavonDavis Made requested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that the services dropdown navigate to the right page