Open
Conversation
dimitriharding
requested changes
Oct 31, 2022
Contributor
dimitriharding
left a comment
dimitriharding
left a comment
There was a problem hiding this comment.
Please see the comments to understand where changes are needed.
| // and print "Maths paper marked" | ||
| return new Promise((resolve, reject) => { | ||
|
|
||
| setTimeout(() => resolve("Math paper marked"), 2000); |
Contributor
There was a problem hiding this comment.
Expected text to be "Maths paper marked"
Suggested change
| setTimeout(() => resolve("Math paper marked"), 2000); | |
| setTimeout(() => resolve("Maths paper marked"), 2000); |
|
|
||
| if(paper.wasSubmitted){ | ||
|
|
||
| paper.markPaper(); |
Contributor
There was a problem hiding this comment.
Expected you to use the await keyword so that way, the execution would have waited for your promise to be resolved rather than for you to update the test cases to use setTimeout before checking the results.
Suggested change
| paper.markPaper(); | |
| await paper.markPaper(); |
| constructor(wheels, bodyType) { | ||
| this.wheels = wheels; | ||
| this.bodyType = bodyType; | ||
| } |
Contributor
There was a problem hiding this comment.
Classes allow us to reuse code, so you were expected to define the whatIsMyName method on the Vehicle class so all child classes would automatically have the same method rather than you defining it on each class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Complete.