[numpy_vs_numba_vs_jax] Fix race condition in parallel Numba implementation #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The parallel Numba implementation in the NumPy vs Numba vs JAX lecture had a race condition bug that caused it to return incorrect results.
The Bug
The original code had multiple threads simultaneously updating a shared variable
m:This returned
-infinstead of the correct maximum (~0.9999).The Fix
Each thread now computes its own row maximum, stored in a thread-safe array:
Verification
-inf0.99999799866800240.9999979986680024Changes
mwith thread-saferow_maxesarrayrow_maxnp.max(row_maxes)combines partial results