Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 44 44
Lines 5645 5647 +2
=======================================
+ Hits 4690 4692 +2
Misses 955 955 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'd be okay with disabling the AD tests on nightly altogether to be honest, it's very often that this causes issues |
|
Do you know how to easily check whether the version it is running on is nightly or a stable version? |
|
I don't, and I'm not sure it's actually possible... JuliaDiff/ChainRulesTestUtils.jl#294 should resolve the issue though. As a side-note, I'm also not sure how valuable these nightly build tests are at all. I don't think we are really that strongly depending on any internals to expect breaking code, and we wouldn't catch performance changes anyways. I'm also okay with just disabling this altogether. |
|
Ok, new attempt, now disabling AD tests at nightly altogether. I am not ready to give up nightly tests alltogether. |
|
Looks like that worked 😉 |
No description provided.