Skip to content

Try enabling the complex tests for Mooncake #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 5 commits into from
Jan 27, 2026
Merged

Try enabling the complex tests for Mooncake #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b80ff89
Try enabling the complex tests for Mooncake
kshyatt Jan 26, 2026
95132cb
StridedNative and StridedBlas don't work with complex tangents
kshyatt Jan 26, 2026
5ea75c3
bump minimal Mooncake version
lkdvos Jan 26, 2026
740743b
remove use of `Mooncake._rdata`
lkdvos Jan 26, 2026
a9c6002
enable tests
lkdvos Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ DynamicPolynomials = "0.5, 0.6"
LRUCache = "1"
LinearAlgebra = "1.6"
Logging = "1.6"
Mooncake = "0.4.195"
Mooncake = "0.5"
PackageExtensionCompat = "1"
PrecompileTools = "1.1"
Preferences = "1.4"
Expand Down
12 changes: 6 additions & 6 deletions ext/TensorOperationsMooncakeExt/TensorOperationsMooncakeExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ function Mooncake.rrule!!(
function contract_pb(::NoRData)
scale!(C, C_cache, One())
dC, dA, dB, Δα, Δβ = TensorOperations.tensorcontract_pullback!(dC, dA, dB, C, A, pA, conjA, B, pB, conjB, pAB, α, β, ba...)
dα = isnothing(Δα) ? NoRData() : Mooncake._rdata(Δα)
dβ = isnothing(Δβ) ? NoRData() : Mooncake._rdata(Δβ)
dα = isnothing(Δα) ? NoRData() : Δα
dβ = isnothing(Δβ) ? NoRData() : Δβ
return NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), dα, dβ, map(ba_ -> NoRData(), ba)...
end
return C_dC, contract_pb
Expand Down Expand Up @@ -90,8 +90,8 @@ function Mooncake.rrule!!(
function add_pb(::NoRData)
scale!(C, C_cache, One())
dC, dA, Δα, Δβ = TensorOperations.tensoradd_pullback!(dC, dA, C, A, pA, conjA, α, β, ba...)
dα = isnothing(Δα) ? NoRData() : Mooncake._rdata(Δα)
dβ = isnothing(Δβ) ? NoRData() : Mooncake._rdata(Δβ)
dα = isnothing(Δα) ? NoRData() : Δα
dβ = isnothing(Δβ) ? NoRData() : Δβ
return NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), dα, dβ, map(ba_ -> NoRData(), ba)...
end
return C_dC, add_pb
Expand Down Expand Up @@ -122,8 +122,8 @@ function Mooncake.rrule!!(
function trace_pb(::NoRData)
scale!(C, C_cache, One())
dC, dA, Δα, Δβ = TensorOperations.tensortrace_pullback!(dC, dA, C, A, p, q, conjA, α, β, ba...)
dα = isnothing(Δα) ? NoRData() : Mooncake._rdata(Δα)
dβ = isnothing(Δβ) ? NoRData() : Mooncake._rdata(Δβ)
dα = isnothing(Δα) ? NoRData() : Δα
dβ = isnothing(Δβ) ? NoRData() : Δβ
return NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), NoRData(), dα, dβ, map(ba_ -> NoRData(), ba)...
end
return C_dC, trace_pb
Expand Down
12 changes: 6 additions & 6 deletions test/mooncake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ is_primitive = false
(
(Float64, Float64),
(Float32, Float64),
#(ComplexF64, ComplexF64),
#(Float64, ComplexF64),
(ComplexF64, ComplexF64),
(Float64, ComplexF64),
)
T = promote_type(T₁, T₂)
atol = max(precision(T₁), precision(T₂))
Expand All @@ -37,8 +37,8 @@ end
(
(Float64, Float64),
(Float32, Float64),
#(ComplexF64, ComplexF64),
#(Float64, ComplexF64),
(ComplexF64, ComplexF64),
(Float64, ComplexF64),
)
T = promote_type(T₁, T₂)
atol = max(precision(T₁), precision(T₂))
Expand All @@ -60,8 +60,8 @@ end
(
(Float64, Float64),
(Float32, Float64),
#(ComplexF64, ComplexF64),
#(Float64, ComplexF64),
(ComplexF64, ComplexF64),
(Float64, ComplexF64),
)
T = promote_type(T₁, T₂)
atol = max(precision(T₁), precision(T₂))
Expand Down
Loading