core/lib: control assert with CONFIG_* macros #21963
Open
+69
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This brings the compile time configuration of assert in line with current expectations:
CONFIG_prefix1to enable a feature. When undefined or defined as0, the feature is disabled.To not break existing code, backward compatibility is added. If the old macros are used, a notice about the use of the deprecated macro and what to use instead is printed.
Testing procedure
Adding
CFLAGS += -DDEBUG_ASSERT_VERBOSEshould still give verbose assertion messages, but also print:Adding
CFLAGS += -DCONFIG_ASSERT_VERBOSE=1should give verbose asserts, e.g.Defining it to
0or not defining it should give compact asserts instead, e.g.Note
If testing on
native*: Inmakefiles/arch/native.inc.mk:129verbose assertions are forced (already inmaster).Issues/PRs references
None