cpu/stm32: simplify handling of generated IRQ header #21964
+12
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: ARM
Member
Author
Output of |
maribu
added
Type: cleanup
aabadie
approved these changes
Dec 22, 2025
Contributor
|
IIRC, once this is in master, users who already built firmwares for stm32 will have to manually remove the previously generated STM32 IRQ headers. |
maribu
force-pushed
the
cpu/stm32/simplify-irqs-header
branch
from
d77faa4 to
1f1b55a
Compare
- rename `irqs/<CPU_FAM>/irqs.h` to `irqs/<CPU_FAM>/stm32_irqs.h` to
reduce chance of a name conflict (`irqs.h` might not be unique)
- add `irqs/<CPU_FAM>` to the include paths
- add the `#include "stm32{f0,f1,f2,f3,f4,f7,l0,...}xx.h"` to the
generated `stm32_irqs.h`
==> Now we can just go for `#include "stm32_irqs.h` and drop a lot of
preprocessor conditionals
maribu
force-pushed
the
cpu/stm32/simplify-irqs-header
branch
from
1f1b55a to
b60df58
Compare
Member
Author
|
I added a simple cleanup and a note to remove the cleanup after the next release branch has been created. This will only remove the |
Member
Author
|
Hmm, I wonder if it is better to just document that users should run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
irqs/<CPU_FAM>/irqs.htoirqs/<CPU_FAM>/stm32_irqs.hto reduce chance of a name conflict (irqs.hmight not be unique)irqs/<CPU_FAM>to the include paths#include "stm32{f0,f1,f2,f3,f4,f7,l0,...}xx.h"to the generatedstm32_irqs.h==> Now we can just go for
#include "stm32_irqs.hand drop a lot of preprocessor conditionalsTesting procedure
The generated binaries should not change
Issues/PRs references
None