build system: don't create riotbuild.h #21967
Draft
+117
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
the
CI: ready for build
github-actions
bot
added
Area: doc
maribu
force-pushed
the
build-system/do-not-use-riotbuild
branch
from
ecbd1df to
122b27a
Compare
- Use a constant `riotbuild.h` header that contains deprecations of macros and documentation and pass that with `-include`, just like the old dynamic file - Pass regular CFLAGS just add command line flags - Write `-DMODULE_...` defines to `$(BINDIR)/module_defines.txt` and add that as arguments that using `@<FILE>` syntax. Older systems may be more constraint with the length of the command line supported, and the module defines are the main contributor to an overlong command line. - Add a hash of `$(CFLAGS)` and use that to trigger rebuild of all .o files when changed - drop tools needed for creating `riotbuild.h` - those are not needed anymore Fixes RIOT-OS#21966
Using `cmp` and `mv` can be noticeably faster than a python script, mostly due to python's slow start up time.
maribu
force-pushed
the
build-system/do-not-use-riotbuild
branch
from
122b27a to
fbfcac0
Compare
Contributor
|
--------
okay, so going away from riotbuild.h towards -D only.
Not the direction I would go, but I agree with doing this once.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
riotbuild.hheader that contains deprecations of macros and documentation and pass that with-include, just like the old dynamic file-DMODULE_...defines to$(BINDIR)/module_defines.txtand add that as arguments that using@<FILE>syntax. Older systems may be more constraint with the length of the command line supported, and the module defines are the main contributor to an overlong command line.$(CFLAGS)and use that to trigger rebuild of all .o files when changedriotbuild.h- those are not needed anymoreTesting procedure
Generated binaries should not change
Issues/PRs references
Fixes #21966